J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1972069279
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -1303,7 +1303,7 @@ private void handleLegacySchemaConfig(TableConfig
tableConfig, HttpHeaders httpH
private void validateInstanceAssignment(TableConfig tableConfig) {
TableRebalancer tableRebalancer = new
TableRebalancer(_pinotHelixResourceManager.getHelixZkManager());
try {
- tableRebalancer.getInstancePartitionsMap(tableConfig, true, true, true);
+ tableRebalancer.getInstancePartitionsMap(tableConfig, true, true, true,
false);
Review Comment:
I did not write one for `TableRebalancer.getInstancePartitionsMap`. Since
this is the only place that uses this method outside of `TableRebalancer`,
should we add another signature to default the argument just for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
