gortiz commented on code in PR #15143:
URL: https://github.com/apache/pinot/pull/15143#discussion_r1975455876
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -177,6 +178,12 @@ public void init(PinotConfiguration config,
InstanceDataManager instanceDataMana
_executorService =
ExecutorServiceUtils.create(config,
Server.MULTISTAGE_EXECUTOR_CONFIG_PREFIX, "query-runner-on-" + port,
Server.DEFAULT_MULTISTAGE_EXECUTOR_TYPE);
+
+ int maxThreads =
config.getProperty(Server.CONFIG_OF_MSE_THREADS_HARD_LIMIT,
Server.DEFAULT_MSE_THREADS_HARD_LIMIT);
+ if (maxThreads > 0) {
+ _executorService = new MaxTasksExecutor(maxThreads, _executorService);
+ }
Review Comment:
I don't think we should use the provider api here. I'm adding more info why
and the changes we should apply in case we want to use that API in another
batch review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
