gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975642350
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -353,12 +348,15 @@ private InstanceResponseBlock
executeInternal(ServerQueryRequest queryRequest, E
// NOTE most likely the onFailure() callback registered on query
future in InstanceRequestHandler would
// return the error table to broker sooner than here. But in case of
race condition, we construct the error
// table here too.
-
instanceResponse.addException(QueryException.getException(QueryException.QUERY_CANCELLATION_ERROR,
- "Query cancelled on: " + _instanceDataManager.getInstanceId() + "
" + e));
+ instanceResponse.addException(QueryErrorCode.QUERY_CANCELLATION,
+ "Query cancelled on: " + _instanceDataManager.getInstanceId() + "
" + e);
+ } else if (e instanceof QueryException) {
+ LOGGER.info("Caught QueryException while processing requestId: {},
{}", requestId, e.getMessage());
+ instanceResponse.addException(QueryErrorCode.QUERY_VALIDATION,
e.getMessage());
Review Comment:
This catches all the errors that were seen as a BadQueryRequestException
before. Should they be considered validation errors? Not sure, we can discuss
that in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
