snleee commented on a change in pull request #4615: Update Getting Started documentation. URL: https://github.com/apache/incubator-pinot/pull/4615#discussion_r325418567
########## File path: docs/getting_started.rst ########## @@ -114,7 +114,25 @@ Suppose we have a transcript in CSV format containing students' basic info and t | 202 | Nick | Young | Male | Physics | 3.6 | +------------+------------+-----------+-----------+-----------+-----------+ -Firstly in order to set up a table, we need to specify the schema of this transcript. +We will not include a header line in this CSV file: + +.. code-block:: none + + 200,Lucy,Smith,Female,Maths,3.8 + 200,Lucy,Smith,Female,English,3.5 + 201,Bob,King,Male,Maths,3.2 + 202,Nick,Young,Male,Physics,3.6 + +Instead of using a header line, we will use a separate CSV config JSON file: + +.. code-block:: none Review comment: It's a bit not clear on where we store these code blocks. I think that we should mention that we store the original data file @ `$WORKING_DIR/data/` and csv config @ `$WORKING_DIR/config/csv-record-reader-config.json` Same for all code blocks representing the files :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
