deepthi912 commented on code in PR #15178:
URL: https://github.com/apache/pinot/pull/15178#discussion_r1982295648
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -892,8 +892,13 @@ public void run() {
}
} catch (Throwable e) {
if (_shouldStop) {
- _segmentLogger.info("Caught exception in consumer thread after
stop() is invoked: {}, ignoring the exception",
- e.toString());
+ if (_segmentLogger.isDebugEnabled()) {
+ e.printStackTrace();
Review Comment:
Sorry, got misunderstood with printing stack trace. Updated!
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/BasePartitionDedupMetadataManager.java:
##########
@@ -283,8 +283,13 @@ public void removeSegment(IndexSegment segment) {
return;
}
try {
- if (skipSegmentOutOfTTL(segment, false)) {
- return;
+ // segment.getSegmentMetadata().getColumnMetadataMap() will be null when
offloading a temporary segment data
+ // manager created in BaseTableDataManager.addSegment which caused
replicas to go into BAD state when
+ // metadataTTL is set
+ if (segment.getSegmentMetadata() != null &&
segment.getSegmentMetadata().getColumnMetadataMap() != null) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
