klsince commented on code in PR #15206:
URL: https://github.com/apache/pinot/pull/15206#discussion_r1983831839
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -204,7 +205,11 @@ Map<String, List<Operation>>
computeOperations(SegmentDirectory.Reader segmentRe
for (String column : existingAllColumns) {
if (_schema != null && !_schema.hasColumn(column)) {
// _schema will be null only in tests
- LOGGER.info("Column: {} of segment: {} is not in schema, skipping
updating forward index", column, segmentName);
+ if
(!CommonConstants.Segment.BuiltInVirtualColumn.ALL_COLUMNS.contains(column)) {
Review Comment:
updated comment for this observation
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -204,7 +205,11 @@ Map<String, List<Operation>>
computeOperations(SegmentDirectory.Reader segmentRe
for (String column : existingAllColumns) {
if (_schema != null && !_schema.hasColumn(column)) {
// _schema will be null only in tests
- LOGGER.info("Column: {} of segment: {} is not in schema, skipping
updating forward index", column, segmentName);
+ if
(!CommonConstants.Segment.BuiltInVirtualColumn.ALL_COLUMNS.contains(column)) {
Review Comment:
In fact, `_schema` might contain those virtual columns as there is this
`addBuiltInVirtualColumnsToSegmentSchema` method being called at some code
paths. As my knowledge of this fwd handler is limited, I'm playing safe here to
just avoid the log msg for virtual columns. So. in case when virtual columsn
are in schema, the following handling logic is not skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
