minwoo-jung commented on code in PR #15216:
URL: https://github.com/apache/pinot/pull/15216#discussion_r1984532112
##########
pom.xml:
##########
@@ -1375,8 +1375,8 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop.thirdparty</groupId>
Review Comment:
@NihalJain Hello
I am not a Pinot developer, so I'm not entirely sure about the intention
behind this. However, in the past, the HDFS library was not included directly
in the package. But, in recent versions, I noticed that the library is included
as a shaded dependency. So, it seems that the version management policy for the
HDFS library has changed. It would be best for the responsible person to check
whether this is the case or if we need to modify it to avoid including the
library.
Additionally, depending on the policy regarding the HDFS library, the
relevant guide documentation may also need to be updated, so I've asked the
team to check that.
Furthermore, when using libraries that are sensitive to versions, these
issues are quite common. However, I also know well that implementing it to work
properly regardless of the library version is not easy. ^^
Enforcing a specific version of a library might be inconvenient when using
compatible versions, but there are also advantages. For libraries sensitive to
security and performance, enforcing a specific version is much better for
stability.
If we do not enforce library versions, the usability would certainly
increase, but it’s impossible to make the system work for all versions. So,
personally, I try to enforce specific library versions, while documenting the
compatible versions (e.g., in the README).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
