bziobrowski commented on code in PR #15130:
URL: https://github.com/apache/pinot/pull/15130#discussion_r1984651226
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java:
##########
@@ -110,11 +127,19 @@ protected void doInit() {
}
if (_disablePreload) {
+ Object2LongOpenCustomHashMap<Object[]> lookupTable = new
Object2LongOpenCustomHashMap<>(HASH_STRATEGY);
Review Comment:
This shouldn't be a concern here because lookup table :
- is pre-sized correctly before eager load
- is not modified after creation
- is never loaded partially but from scratch in
`DimensionTableDataManager.loadLookupTable()` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
