jadami10 commented on PR #15221: URL: https://github.com/apache/pinot/pull/15221#issuecomment-2708490943
> This might result in double counting though. ya, that's my concern. I copied https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java#L327-L329 which effectively does the same thing. Looking at [BrokerMeter](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java#L32-L58), It seems the strategy is to append "global" to a metric name and remove the table info? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
