ankitsultana commented on code in PR #15225:
URL: https://github.com/apache/pinot/pull/15225#discussion_r1989987869
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java:
##########
@@ -47,23 +47,23 @@ private PinotImplicitTableHintRule(Config config) {
public static PinotImplicitTableHintRule withWorkerManager(WorkerManager
workerManager) {
return new
PinotImplicitTableHintRule(ImmutablePinotImplicitTableHintRule.Config.builder()
- .operandSupplier(b0 -> b0.operand(LogicalTableScan.class).anyInputs())
+ .operandSupplier(b0 ->
b0.operand(PinotLogicalTableScan.class).anyInputs())
Review Comment:
Yeah using `TableScan` here would be better since this rule is not dependent
on either Logical table scan or the new Pinot named variant. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
