akshayrai commented on a change in pull request #4621: [TE] fix the last time
stamp filter out the generated anomalies
URL: https://github.com/apache/incubator-pinot/pull/4621#discussion_r326394084
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java
##########
@@ -476,7 +477,11 @@ public Response detectionReplay(
}
for (MergedAnomalyResultDTO anomaly : result.getAnomalies()) {
- anomaly.setAnomalyResultSource(AnomalyResultSource.ANOMALY_REPLAY);
+ // if would like to skip sending the alert emails, the anomalies
should be marked with REPLAY
+ // otherwise, should be left as the default source
+ if (!sendEmail) {
+ anomaly.setAnomalyResultSource(AnomalyResultSource.ANOMALY_REPLAY);
Review comment:
I still don't think this might be a good way. let's discuss this offline. I
have 2 concerns.
1. If we are replaying it then I think we should always set the source to
ANOMALY_REPLAY to distinguish it from a regular detection, irrespective of the
email report.
2. In case we are replaying the detection for some historical window, the
alerter watermark can prevent it from sending the replayed anomalies right!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
