mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327240503
########## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ########## @@ -50,37 +44,27 @@ private final String _segmentName; private final ProjectionPlanNode _projectionPlanNode; private final Set<String> _projectionColumns = new HashSet<>(); - private final Set<TransformExpressionTree> _expressionTrees = new LinkedHashSet<>(); + private final Set<TransformExpressionTree> _expressions = new HashSet<>(); Review comment: Ordering not required anymore? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
