codecov-io edited a comment on issue #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#issuecomment-533946578 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=h1) Report > Merging [#4629](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/eda4176dbe3fdcc61744ab8e0ed3cd1246542c8f?src=pr&el=desc) will **decrease** coverage by `21.97%`. > The diff coverage is `85.44%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4629 +/- ## ============================================= - Coverage 64.47% 42.49% -21.98% ============================================= Files 1072 1073 +1 Lines 55702 55663 -39 Branches 8131 8111 -20 ============================================= - Hits 35913 23654 -12259 - Misses 17131 29912 +12781 + Partials 2658 2097 -561 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `56.63% <0%> (-31.76%)` | `0 <0> (ø)` | | | [...not/core/operator/transform/TransformOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vVHJhbnNmb3JtT3BlcmF0b3IuamF2YQ==) | `94.44% <100%> (-0.8%)` | `0 <0> (ø)` | | | [...e/pinot/core/common/datatable/DataTableImplV2.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZUltcGxWMi5qYXZh) | `87.45% <100%> (-1.97%)` | `0 <0> (ø)` | | | [...java/org/apache/pinot/common/utils/DataSchema.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `54.73% <100%> (-29.14%)` | `0 <0> (ø)` | | | [.../org/apache/pinot/pql/parsers/Pql2AstListener.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QcWwyQXN0TGlzdGVuZXIuamF2YQ==) | `77.98% <100%> (-11.33%)` | `0 <0> (ø)` | | | [.../org/apache/pinot/core/plan/TransformPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1RyYW5zZm9ybVBsYW5Ob2RlLmphdmE=) | `86.95% <100%> (-0.8%)` | `0 <0> (ø)` | | | [...ot/core/operator/query/EmptySelectionOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9FbXB0eVNlbGVjdGlvbk9wZXJhdG9yLmphdmE=) | `94.44% <100%> (+5.55%)` | `0 <0> (ø)` | :arrow_down: | | [.../core/startree/plan/StarTreeTransformPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlVHJhbnNmb3JtUGxhbk5vZGUuamF2YQ==) | `75% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...che/pinot/pql/parsers/pql2/ast/OrderByAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PcmRlckJ5QXN0Tm9kZS5qYXZh) | `41.17% <42.85%> (-43.2%)` | `0 <0> (ø)` | | | [...t/core/query/selection/SelectionOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JVdGlscy5qYXZh) | `65.98% <73.13%> (-22.34%)` | `0 <0> (ø)` | | | ... and [595 more](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=footer). Last update [eda4176...c849dd0](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
