Jackie-Jiang commented on a change in pull request #4634: Remove import of
sun.misc.Cleaner to make code compatible with jdk11
URL: https://github.com/apache/incubator-pinot/pull/4634#discussion_r327722393
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/memory/PinotByteBuffer.java
##########
@@ -328,9 +328,8 @@ public void flush() {
@Override
protected void release() {
- Cleaner cleaner = ((DirectBuffer) _buffer).cleaner();
- if (cleaner != null) {
- cleaner.clean();
+ if ( ((DirectBuffer) _buffer).cleaner() != null) {
Review comment:
(nit) Please reformat this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
