somandal commented on code in PR #15436:
URL: https://github.com/apache/pinot/pull/15436#discussion_r2035821939
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -1333,16 +1352,18 @@ private IdealState waitForExternalViewToConverge(String
tableNameWithType, boole
}
if (isExternalViewConverged(tableNameWithType,
externalView.getRecord().getMapFields(),
Review Comment:
nit: should the `tableRebalanceLogger` be passed in here?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -1070,44 +1083,45 @@ private void onReturnFailure(String errorMsg, Exception
e) {
*/
public Pair<Map<InstancePartitionsType, InstancePartitions>, Boolean>
getInstancePartitionsMap(
TableConfig tableConfig, boolean reassignInstances, boolean bootstrap,
boolean dryRun) {
- return getInstancePartitionsMap(tableConfig, reassignInstances, bootstrap,
dryRun, false);
+ return getInstancePartitionsMap(tableConfig, reassignInstances, bootstrap,
dryRun, false,
+ new TableRebalanceLogger(LOGGER));
Review Comment:
nit: add a comment mentioning that this is called from a code path outside
of rebalance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
