Jackie-Jiang commented on code in PR #15528:
URL: https://github.com/apache/pinot/pull/15528#discussion_r2045677023
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1780,19 +1778,18 @@ ParallelSegmentConsumptionPolicy
getParallelConsumptionPolicy() {
// - For pauseless tables, allow consumption during build, but disallow
consumption during download
// - For non-pauseless tables, disallow consumption during build and
download
// TODO: Revisit the non-pauseless handling
- if (_realtimeTableDataManager.isDedupEnabled()) {
- DedupConfig dedupConfig = _tableConfig.getDedupConfig();
- assert dedupConfig != null;
- if (dedupConfig.isAllowDedupConsumptionDuringCommit()) {
+ if (_partitionUpsertMetadataManager != null) {
+ UpsertContext upsertContext =
_partitionUpsertMetadataManager.getContext();
+ if (upsertContext.isAllowPartialUpsertConsumptionDuringCommit()
+ || upsertContext.getUpsertMode() != UpsertConfig.Mode.PARTIAL) {
Review Comment:
Yeah, I just changed it to use context as source of truth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
