ankitsultana commented on code in PR #15473:
URL: https://github.com/apache/pinot/pull/15473#discussion_r2048210586
##########
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java:
##########
@@ -70,6 +70,16 @@ boolean mkdir(URI uri)
boolean delete(URI segmentUri, boolean forceDelete)
throws IOException;
+ /**
+ * Deletes the files at the locations provided. If the segmentUri is a
directory, it will delete the entire directory.
+ * @param segmentUris List of URIs of the segments
+ * @param forceDelete true if we want the uri and any sub-uris to always be
deleted, false if we want delete to fail
+ * @return true if delete is successful else false
Review Comment:
What if the delete only partially succeeded? Not all filesystems support
batch deletion so some implementation will have to issue the delete in a loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
