fx19880617 commented on a change in pull request #4635: Support ORC files as
data source in segment creation
URL: https://github.com/apache/incubator-pinot/pull/4635#discussion_r327943824
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/PinotDataType.java
##########
@@ -263,21 +264,33 @@ public String convert(Object value, PinotDataType
sourceType) {
OBJECT {
@Override
public Integer toInteger(Object value) {
+ if (value instanceof Number) {
Review comment:
I've seen SHORT/INTEGER/LONGs are set as OBJECT from OrcRecordReader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
