mayankshriv commented on a change in pull request #4645: Adding sample ADL settings to documentation URL: https://github.com/apache/incubator-pinot/pull/4645#discussion_r328333708
########## File path: docs/pluggable_storage.rst ########## @@ -57,6 +57,25 @@ AzurePinotFS requires the following configs according to your environment: adl.accountId, adl.authEndpoint, adl.clientId, adl.clientSecret +Sample Controller Config Review comment: Oh I see, this is not JSON config, but apache PropertiesConfiguration file. In that case, this is fine. Could you please add instruction on how this file is passed to `pinot-server`? Also, please make sure that the output html page is formatted correctly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
