mghildiy commented on code in PR #15377:
URL: https://github.com/apache/pinot/pull/15377#discussion_r2072350236
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java:
##########
@@ -90,18 +90,33 @@ public double[] transformToDoubleValuesSV(ValueBlock
valueBlock) {
double[] leftValues =
_leftTransformFunction.transformToDoubleValuesSV(valueBlock);
if (_fixedScale) {
for (int i = 0; i < length; i++) {
- _doubleValuesSV[i] = BigDecimal.valueOf(leftValues[i])
- .setScale(_scale, RoundingMode.HALF_UP).doubleValue();
+ if (leftValues[i] == Double.NEGATIVE_INFINITY || leftValues[i] ==
Double.POSITIVE_INFINITY ||
+ leftValues[i] == Double.NaN) {
Review Comment:
Currently Double.NaN, Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY are
put into null bit map. I am debugging code to ensure that these 3 values are
not part of null bit map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
