Jackie-Jiang commented on code in PR #15672:
URL: https://github.com/apache/pinot/pull/15672#discussion_r2074166131
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java:
##########
@@ -130,7 +130,24 @@ public void process(@Nullable SegmentOperationsThrottler
segmentOperationsThrott
if (type != StandardIndexes.forward()) {
IndexHandler handler = createHandler(type);
indexHandlers.add(handler);
- handler.updateIndices(segmentWriter);
+ try {
+ handler.updateIndices(segmentWriter);
+ } catch (IllegalStateException | UnsupportedOperationException e) {
+ // The index creation failure is expected in some cases, like when
the index is not supported for the
+ // column or segment type.
+ // E.g. non-dictionary encoded TIMESTAMP type doesn't support
range index, meanwhile dictionary encoded
Review Comment:
I agree we should provide a way to get out of this limbo state (best
effort), but that should be under a flag similar to ingestion
`continueOnError`. Also, we need to have a metric tracking index creation
failures so that user is notified so that they can fix the table config
accordingly.
Ideally such issues should be caught during table config validation. We
should provide this flag just for temporary mitigation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
