vrajat commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2077983162
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1637,6 +1637,12 @@ public Schema getSchemaForTableConfig(TableConfig
tableConfig) {
return ZKMetadataProvider.getTableSchema(_propertyStore, tableConfig);
}
+ public List<String> getAllSchemaNames() {
Review Comment:
Is this only used in the test ? Can `getSchemaNames` be used instead ?
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java:
##########
@@ -74,7 +76,7 @@ public static ZNRecord toZNRecord(LogicalTableConfig
logicalTableConfig)
}
public static void validateLogicalTableName(LogicalTableConfig
logicalTableConfig, List<String> allPhysicalTables,
Review Comment:
Is this function name still appropriate ? I think it should be called
`validateLogicalTableConfig`. Also are the parameters (other than
`propertyStore`) required ? The function already has `logicalTableConfig`
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/PinotHelixPropertyStoreZnRecordProvider.java:
##########
@@ -51,6 +51,10 @@ public static PinotHelixPropertyStoreZnRecordProvider
forSegments(ZkHelixPropert
return new PinotHelixPropertyStoreZnRecordProvider(propertyStore,
"/SEGMENTS");
}
+ public static PinotHelixPropertyStoreZnRecordProvider
forLogicalTable(ZkHelixPropertyStore<ZNRecord> propertyStore) {
Review Comment:
Where is this function used ? browser search failed me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
