somandal commented on code in PR #15735:
URL: https://github.com/apache/pinot/pull/15735#discussion_r2078145990
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -627,7 +627,8 @@ public RebalanceResult rebalance(
+ "contract cannot be achieved)") @DefaultValue("false")
@QueryParam("bestEfforts") boolean bestEfforts,
@ApiParam(value = "How often to check if external view converges with
ideal states") @DefaultValue("1000")
@QueryParam("externalViewCheckIntervalInMs") long
externalViewCheckIntervalInMs,
- @ApiParam(value = "How long to wait till external view converges with
ideal states") @DefaultValue("3600000")
+ @ApiParam(value = "Maximum time (in milliseconds) to wait for external
view to converge with ideal states. Resets"
Review Comment:
nit: instead of "Resets" shall we say "Extends"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
