ankitsultana commented on code in PR #15756:
URL: https://github.com/apache/pinot/pull/15756#discussion_r2081982375
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##########
@@ -77,6 +77,7 @@ public BlockDocIdIterator iterator() {
sortedDocIdIterators.add((SortedDocIdIterator) docIdIterator);
numEntriesScannedForNonScanBasedDocIdSets +=
docIdSet.getNumEntriesScannedInFilter();
} else if (docIdIterator instanceof BitmapBasedDocIdIterator) {
+ bitmapBasedDocIdIterators.add((BitmapBasedDocIdIterator)
docIdIterator);
Review Comment:
@Jackie-Jiang : fyi: this was a regression in 1.2. For one of our use-cases
this increased the latency by almost 100x. The issue is that this can defer the
evaluation of the filters in OR, and if the parent of the Or Filter is an And
with one side of it being a heavy scan, then the scan would end up running
before the Or is run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
