Jackie-Jiang commented on code in PR #15758:
URL: https://github.com/apache/pinot/pull/15758#discussion_r2082328092
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java:
##########
@@ -2346,6 +2346,14 @@ public void testValidateInstancePartitionsMap() {
}
}
+ @Test
+ public void testValidateSkipSegmentPreprocessFlag() {
Review Comment:
This test is for `TableConfigUtils` class. Consider adding a separate test
for `TableConfigBuilder`
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -105,6 +105,7 @@ public class TableConfigBuilder {
private SegmentPartitionConfig _segmentPartitionConfig;
private boolean _nullHandlingEnabled;
private boolean _columnMajorSegmentBuilderEnabled = true;
+ private boolean _skipSegmentPreprocess;
Review Comment:
(minor) Keep the order or variable declaration consistent with methods for
readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
