deepthi912 commented on code in PR #15761:
URL: https://github.com/apache/pinot/pull/15761#discussion_r2085130667
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -819,6 +819,14 @@ static void validateTTLForUpsertConfig(TableConfig
tableConfig, Schema schema) {
Preconditions.checkState(comparisonColumnDataType.isNumeric(),
"MetadataTTL / DeletedKeysTTL must have comparison column: %s in
numeric type, found: %s", comparisonColumn,
comparisonColumnDataType);
+ } else {
+ String comparisonColumn =
tableConfig.getValidationConfig().getTimeColumnName();
+ if (comparisonColumn != null && !comparisonColumn.isEmpty()) {
Review Comment:
It wasn't done for the timeColumn, we are failing it at ingestion stage:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
