Jackie-Jiang commented on code in PR #15841:
URL: https://github.com/apache/pinot/pull/15841#discussion_r2096524563
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationSpec.java:
##########
@@ -82,6 +82,15 @@ public Map<String, Object> getFunctionParameters() {
return _functionParameters;
}
+ /// Returns `true` if the given [AggregationSpec] does not match the current
one, in which case the star-tree index
+ /// needs to be updated, {@code false} otherwise.
+ /// - Update star-tree if the function parameters or compression codec
changes.
+ /// - Do not update star-tree when index version or config changes to avoid
rebuilding all the star-trees when the
+ /// default index setting changes. This is consistent with the behavior of
forward indexes.
+ public boolean shouldModifyStarTree(AggregationSpec that) {
Review Comment:
This is essentially making the behavior consistent with forward index. See
`ForwardIndexHandler.shouldChangeRawCompressionType()` for more context.
We can revisit this and potentially adding a flag to control the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
