Jackie-Jiang commented on PR #15799: URL: https://github.com/apache/pinot/pull/15799#issuecomment-2902593363
> > Can we restrict the japicmp check to only run in the linter test? Currently it is very strict, and prevent tests from running. Apache Pinot is not mature enough to claim no SPI change/removal is allowed, and we can use it as an indicator to warn people about the SPI changes, but committer should still be able to check the test results and decide whether to proceed with the change. > > Yes, moving from maven to GHA is also one approach that I noted into the proposal. One concern is that maybe one committer's approval may not be sufficient to inform all/most consumers so a different override rule can be probably adopted That's not make it that strict and trust committer's judgement. We don't want this becomes a blocker for contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
