abhishekbafna commented on code in PR #15862:
URL: https://github.com/apache/pinot/pull/15862#discussion_r2104371118
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/timeboundary/TimeBoundaryStrategy.java:
##########
@@ -43,4 +44,12 @@ public interface TimeBoundaryStrategy {
*/
TimeBoundaryInfo computeTimeBoundary(LogicalTableConfig logicalTableConfig,
TableCache tableCache,
RoutingManager routingManager);
+
+
+ /**
+ * Returns the list of physical table names that are part of the time
boundary.
+ * @param logicalTableConfig The logical table configuration
+ * @return The list of physical table names that are part of the time
boundary.
+ */
+ List<String> getTimeBoundaryTableNames(LogicalTableConfig
logicalTableConfig);
Review Comment:
My thinking, time boundary will be determined based on a set of [offline]
tables though calculation could be min, max or something else.
I think, `_routingEntryMap` should not be passed to other classes and its
management should remain with in `BrokerRoutingManager`. Also, each strategy
need to implement the `cleanup` method and why it would be different for
different strategy.
The time boundary specific tables will be required to build and remove
routing, why it should be done in strategy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
