gortiz commented on code in PR #15919:
URL: https://github.com/apache/pinot/pull/15919#discussion_r2113604487


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -204,11 +204,7 @@ protected MseBlock getNextBlock() {
     try {
       MseBlock block = _input.nextBlock();
       if (block.isEos()) {
-        if (_context.isSendStats()) {
-          sendEos((MseBlock.Eos) block);
-        } else {
-          sendEos(SuccessMseBlock.INSTANCE);
-        }

Review Comment:
   This was erroneous. In case the block was an error and isSendStats was 
false, we sent a successful EOS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to