akshayrai commented on a change in pull request #4548: [TE] correct time format
before send query to Vertica
URL: https://github.com/apache/incubator-pinot/pull/4548#discussion_r329322228
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/sql/SqlUtils.java
##########
@@ -581,6 +581,15 @@ private static String timeFormatToMySQLFormat(String
timeFormat) {
}
}
+ private static String timeFormatToVerticaFormat(String timeFormat) {
+ if(timeFormat.contains("mm")){
Review comment:
can you format this if block?
* Add space `if<space>(`
* Use 2 space for indentation
* In-line else condition
```
if (condition) {
// do something
} else {
// do something
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
