Jackie-Jiang commented on a change in pull request #4560: Refactor
toggleInstanceState API
URL: https://github.com/apache/incubator-pinot/pull/4560#discussion_r329686963
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2140,52 +2140,71 @@ public PinotResourceManagerResponse
dropInstance(String instanceName) {
* Keeps checking until ideal-state is successfully updated or times out.
*
* @param instanceName: Name of Instance for which the status needs to be
toggled.
- * @param toggle: 'True' for ONLINE 'False' for OFFLINE.
- * @param timeOutInSeconds: Time-out for setting ideal-state.
+ * @param enableInstance: 'True' for enabling the instance and 'False' for
disabling the instance.
+ * @param timeOutMs: Time-out for setting ideal-state.
* @return
*/
- public PinotResourceManagerResponse toggleInstance(String instanceName,
boolean toggle, int timeOutInSeconds) {
+ private PinotResourceManagerResponse enableInstance(String instanceName,
boolean enableInstance, long timeOutMs) {
Review comment:
By convention, toggle means ENABLE/DISABLE/DROP (Check
PinotInstanceRestletResource). This method is called by enableInstance and
disableInstance, so IMO enableInstance is a better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
