praveenc7 commented on code in PR #15350:
URL: https://github.com/apache/pinot/pull/15350#discussion_r2125267956
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/SegmentPrunerService.java:
##########
@@ -105,7 +106,8 @@ public List<IndexSegment> prune(List<IndexSegment>
segments, QueryContext query,
public List<IndexSegment> prune(List<IndexSegment> segments, QueryContext
query, SegmentPrunerStatistics stats,
@Nullable ExecutorService executorService) {
try (InvocationScope scope =
Tracing.getTracer().createScope(SegmentPrunerService.class)) {
- segments = removeInvalidSegments(segments, query, stats);
+ segments = segments.stream()
+ .filter(segment ->
!SegmentPrunerService.isEmptySegment(segment)).collect(Collectors.toList());
Review Comment:
We can't keep the logic of pruning out segments if they don't have the
column, since the virtual column is not yet populated
OR
if you are just referring to keep the empty segments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
