songwdfu commented on PR #15999: URL: https://github.com/apache/pinot/pull/15999#issuecomment-2946422552
> That may not be guaranteed to be the same across Calcite version upgrades. I see this. Our current explain plan uses RelOptRule.toString() as the display name, which returns the rule description. This is also subject to change if the default description is changed in Calcite. So I'm proposing to explicitly assign a description with a defined constant when instantiating each rule. In this way the identifier of the rule would always be controlled by us (which will always be its description), renaming rules would be easy by just changing the constant, and we can upgrade / replace certain rules with Pinot version while keeping the same name. I think this is similar to the idea of defining a wrapper around rules, except we utilize the description field of RelOptRules, which is intended for this. Please let me know if this makes sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
