fx19880617 commented on a change in pull request #4664: Support other
filesystems for Pinot Hadoop job
URL: https://github.com/apache/incubator-pinot/pull/4664#discussion_r330708381
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentCreationMapper.java
##########
@@ -148,7 +148,8 @@ public void setup(Context context)
Preconditions.checkState(_localSegmentDir.mkdir());
Preconditions.checkState(_localSegmentTarDir.mkdir());
- _fileSystem = FileSystem.get(context.getConfiguration());
+ // Note: we made an assumption that input file and output path are using
same filesystem.
+ _fileSystem = FileSystem.get(_hdfsSegmentTarDir.toUri(),
context.getConfiguration());
Review comment:
This filesystem should be same as where we want to store the segment tars.
If we use s3a path as segment tar dir. Then this should be s3a filesystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
