This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8c98168f059 Avoid writing incorrect rebalance progress stats for table
rebalances with instance reassignment but no segment rebalance (#16140)
8c98168f059 is described below
commit 8c98168f0595dfb40590c837108c7f07cdd82a08
Author: Yash Mayya <[email protected]>
AuthorDate: Wed Jun 18 16:15:18 2025 +0100
Avoid writing incorrect rebalance progress stats for table rebalances with
instance reassignment but no segment rebalance (#16140)
---
.../controller/helix/core/rebalance/TableRebalancer.java | 14 ++++----------
.../java/org/apache/pinot/tools/RealtimeQuickStart.java | 2 +-
2 files changed, 5 insertions(+), 11 deletions(-)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
index 810a8b1a4a2..0d9afef7a2b 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
@@ -361,16 +361,10 @@ public class TableRebalancer {
return new RebalanceResult(rebalanceJobId,
RebalanceResult.Status.NO_OP, "Table is already balanced",
instancePartitionsMap, tierToInstancePartitionsMap,
targetAssignment, preChecksResult, summaryResult);
} else {
- if (dryRun) {
- return new RebalanceResult(rebalanceJobId,
RebalanceResult.Status.DONE,
- "Instance reassigned in dry-run mode, table is already balanced",
- instancePartitionsMap, tierToInstancePartitionsMap,
targetAssignment, preChecksResult, summaryResult);
- } else {
- _tableRebalanceObserver.onSuccess("Instance reassigned but table is
already balanced");
- return new RebalanceResult(rebalanceJobId,
RebalanceResult.Status.DONE,
- "Instance reassigned, table is already balanced",
instancePartitionsMap,
- tierToInstancePartitionsMap, targetAssignment, preChecksResult,
summaryResult);
- }
+ tableRebalanceLogger.info("Instance reassigned but table is already
balanced");
+ return new RebalanceResult(rebalanceJobId, RebalanceResult.Status.DONE,
+ "Instance reassigned, table is already balanced",
instancePartitionsMap,
+ tierToInstancePartitionsMap, targetAssignment, preChecksResult,
summaryResult);
}
}
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
index d5033b4e907..2382353462d 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
@@ -99,7 +99,7 @@ public class RealtimeQuickStart extends QuickStartBase {
Preconditions.checkState(quickstartRunnerDir.mkdirs());
List<QuickstartTableRequest> quickstartTableRequests =
bootstrapStreamTableDirectories(quickstartTmpDir);
final QuickstartRunner runner =
- new QuickstartRunner(quickstartTableRequests, 1, 1, 1, 1,
quickstartRunnerDir, getConfigOverrides());
+ new QuickstartRunner(quickstartTableRequests, 1, 1, 4, 1,
quickstartRunnerDir, getConfigOverrides());
startKafka();
startAllDataStreams(_kafkaStarter, quickstartTmpDir);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
