UOETianleZhang opened a new pull request, #16180: URL: https://github.com/apache/pinot/pull/16180
## Summary We want to migrate certain API files to pinot-spi for compatibility gating. broker.api.AccessControl, server.access.AccessControl, and controller.api.access.AccessControl can all be migrated to pinot-spi by: - Migrating their necessary dependencies - ex. common.request.BrokerRequest - to pinot-spi. - Updating the pinot-spi pom with the io.netty, javax.ws.rs, javax.annotation and thrift dependencies. - Disabling the checkstyle checks for the thrift-generated files that were migrated in config/suppressions.xml. - Applying mvn spotless:apply. ## Major Code Change Most of files in the PR are generated files. The core changes are only on two thrift files: - moved pinot-common/src/thrift/query.thrift to pinot-spi - moved part of request.thrift into two same-named files in spi ## Name Change - broker.api.AccessControl --> spi.auth.broker.AccessControl - broker.api.RequesterIdentity --> spi.auth.broker.RequesterIdentity - common.request.BrokerRequest --> spi.request.BrokerRequest - common.request.DataSource --> spi.request.DataSource - common.request.Expression --> spi.request.Expression - common.request.ExpressionType --> spi.request.ExpressionType - common.request.Function --> spi.request.Function - common.request.Identifier --> spi.request.Identifier - common.request.Join --> spi.request.Join - common.request.JoinType --> spi.request.JoinType - common.request.Literal --> spi.request.Literal - common.request.PinotQuery --> spi.request.PinotQuery - common.request.QuerySource --> spi.request.QuerySource - controller.api.access.AccessControl --> spi.auth.controller.AccessType - controller.api.access.AccessType --> spi.auth.controller.AccessType - core.auth.FineGrainedAccessControl --> spi.auth.core.FineGrainedAccessControl - core.auth.TargetType --> spi.auth.core.TargetType - server.access.AccessControl --> spi.auth.server.AccessControl - server.access.RequesterIdentity --> spi.auth.server.RequesterIdentity - query.thrift (originally in pinot-common/thrift) - request.thrift (split into two files, one is still in pinot-common/thrift) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
