somandal commented on code in PR #16146:
URL: https://github.com/apache/pinot/pull/16146#discussion_r2167792513
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -903,7 +912,7 @@ protected List<PeriodicTask> setupControllerPeriodicTasks()
{
_controllerMetrics, _executorService, _connectionManager);
periodicTasks.add(responseStoreCleaner);
PeriodicTask resourceUtilizationChecker = new
ResourceUtilizationChecker(_config, _connectionManager,
- _controllerMetrics, _diskUtilizationChecker, _executorService,
_helixResourceManager);
+ _controllerMetrics, _utilizationCheckers, _executorService,
_helixResourceManager);
Review Comment:
why would we do that? the manager is just for checking the status, whereas
the checker updates the in-memory state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
