This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new af48abc Mocking out the LeadControllerManager in test (#4677)
af48abc is described below
commit af48abce79de1482c757c3f250ee0a584f423b05
Author: Subbu Subramaniam <[email protected]>
AuthorDate: Thu Oct 3 18:25:04 2019 -0700
Mocking out the LeadControllerManager in test (#4677)
* Mocking out the LeadControllerManager in test
We should not need the real one, so it is better to mock the class
altogether
* Addressing review comment
---
.../helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
index 3396066..aaee7e5 100644
---
a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
+++
b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
@@ -1321,8 +1321,7 @@ public class PinotLLCRealtimeSegmentManagerTest {
protected FakePinotLLCRealtimeSegmentManager(PinotHelixResourceManager
pinotHelixResourceManager,
List<String> existingLLCSegments, ControllerMetrics controllerMetrics)
{
- super(pinotHelixResourceManager, CONTROLLER_CONF, controllerMetrics,
- new
LeadControllerManager(pinotHelixResourceManager.getHelixZkManager(),
controllerMetrics));
+ super(pinotHelixResourceManager, CONTROLLER_CONF, controllerMetrics,
mock(LeadControllerManager.class));
try {
TableConfigCache mockCache = mock(TableConfigCache.class);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
