noob-se7en commented on code in PR #16278:
URL: https://github.com/apache/pinot/pull/16278#discussion_r2184577298
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java:
##########
@@ -97,6 +97,9 @@ public void acquire(LLCSegmentName llcSegmentName)
while (!_semaphore.tryAcquire(WAIT_INTERVAL_MS, TimeUnit.MILLISECONDS)) {
LOGGER.warn("Failed to acquire consumer semaphore for segment: {} in:
{}ms. Retrying.", segmentName,
System.currentTimeMillis() - startTimeMs);
+
_serverMetrics.addTimedTableValue(_realtimeTableDataManager.getTableName(),
Review Comment:
Can do that. Here with timer I would have added alert on any 1 of below
`pinot_server_consumerSemaphoreAcquireTimeMs_OneMinuteRate{database="airlineStats_REALTIME",table="airlineStats_REALTIME.2"}
0.38528746205225817`
`pinot_server_consumerSemaphoreAcquireTimeMs_Count{database="airlineStats_REALTIME",table="airlineStats_REALTIME.1"}
332.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
