shauryachats commented on issue #16287: URL: https://github.com/apache/pinot/issues/16287#issuecomment-3042341561
> @icefury71: Looks very useful. Can we also add query response stats ? In the future, it'll be good to make this appear similar to the regular SQL (Tracing, export to CSV, Format, Json view etc) Thanks for calling that out. We are currently reconsidering the current Prometheus-compatible timeseries API to include the query stats and make it more Pinot compatible (as mentioned in this issue https://github.com/apache/pinot/issues/15974). Once that is done, the query stats would be added to the UI as a fast follow-up. > @jayeshchoudhary: [NIT] the copy button looks entirely separate from json editor maybe add a floating button in the right corner of json editor It is similar to the current UI for the SQL query flow where we have "Excel", "CSV" and "Copy" buttons disjoint from the JSON Editor, just that currently the Excel and CSV are not valid for the timeseries API yet. > @jayeshchoudhary: how are we surfacing errors? in regular queries we show error instead of result itself Currently, the error is shown in the JSON payload itself. In a subsequent PR, I will adhere to the current error handling mechanism in the timeseries API. > @jayeshchoudhary: [NIT] maybe a better name instead of "Regular Query" I'll rename it to SQL Query. > @jayeshchoudhary: is it possible that TSE is not available or is disabled? if yes then we can only show this view switcher only when TSE is available, wdyt ? I can double-check if TSE is not available, but since it is already released as experimental, I feel it might be better to keep the Timeseries UI (also to draw visibility and more adoption). cc: @ankitsultana -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
