raghavyadav01 commented on code in PR #16298:
URL: https://github.com/apache/pinot/pull/16298#discussion_r2191339809
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/fwd/CLPForwardIndexCreatorV2.java:
##########
@@ -397,8 +397,6 @@ public void seal() {
// Write intermediate files to memory mapped buffer
long totalSize = 0;
- _fileBuffer.putInt(MAGIC_BYTES.length);
Review Comment:
Atleast current code should not work with this because in the reader method
logic is as follows which read Magic Bytes start at 0
if (dataBuffer.size() >= CLPForwardIndexCreatorV2.MAGIC_BYTES.length) {
**byte[] magicBytes = new
byte[CLPForwardIndexCreatorV2.MAGIC_BYTES.length];
dataBuffer.copyTo(0, magicBytes);**
if (Arrays.equals(magicBytes, CLPForwardIndexCreatorV2.MAGIC_BYTES))
{
return new CLPForwardIndexReaderV2(dataBuffer,
metadata.getTotalDocs());
}
}
return createRawIndexReader(dataBuffer,
metadata.getDataType().getStoredType(), metadata.isSingleValue());
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
