yashmayya commented on code in PR #16300:
URL: https://github.com/apache/pinot/pull/16300#discussion_r2192060163
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -786,6 +786,15 @@ public JsonNode cancelQuery(String clientQueryId)
return null; // TODO
}
+ /**
+ * Execute a query and extract the count result
+ */
+ protected int getTotalDocCountFromQuery(String query) throws Exception {
Review Comment:
`TotalDocCount` might be a little misleading since it sounds like the total
number of docs in the table - maybe something like `getQueryNumResultRows`
might be clearer?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -626,6 +626,11 @@ public String forPauseStatus(String tableName) {
return StringUtil.join("/", _baseUrl, "tables", tableName, "pauseStatus");
}
+ public String forValidDocIdsMetadata(String tableName, String
validDocIdsType) {
Review Comment:
nit: maybe allow specifying `null` for `validDocIdsType` to use the default
value?
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -724,6 +749,30 @@ protected long getCurrentCountStarResult(String tableName)
{
return 0;
}
+ protected void waitForMinionTaskCompletion(String taskId) {
+ TestUtils.waitForCondition(aVoid ->
+
_controllerStarter.getHelixTaskResourceManager().getTaskState(taskId) ==
TaskState.COMPLETED,
+ 300_000L, "Failed to complete the task " + taskId);
Review Comment:
nit: it might be useful to allow configuring this timeout via a method
parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
