codecov-io commented on issue #4680: Ensure segment converter not fail for schemas without time fieldSpec URL: https://github.com/apache/incubator-pinot/pull/4680#issuecomment-538635090 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=h1) Report > Merging [#4680](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8249b6ba0d24c06c4f9297418cc50e3a9192c3fb?src=pr&el=desc) will **decrease** coverage by `8.02%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4680 +/- ## ============================================ - Coverage 64.71% 56.69% -8.03% Complexity 16 16 ============================================ Files 1056 1056 Lines 56198 56200 +2 Branches 8332 8334 +2 ============================================ - Hits 36371 31860 -4511 - Misses 17141 21814 +4673 + Partials 2686 2526 -160 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50Q29udmVydGVyLmphdmE=) | `35.71% <85.71%> (-39.29%)` | `0 <0> (ø)` | | | [...e/pinot/core/operator/blocks/EmptyFilterBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvRW1wdHlGaWx0ZXJCbG9jay5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...pache/pinot/core/realtime/stream/MessageBatch.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vTWVzc2FnZUJhdGNoLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...re/data/manager/config/TableDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvY29uZmlnL1RhYmxlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...a/org/apache/pinot/common/metrics/ServerTimer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9TZXJ2ZXJUaW1lci5qYXZh) | `0% <0%> (-88.89%)` | `0% <0%> (ø)` | | | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `0% <0%> (-88.2%)` | `0% <0%> (ø)` | | | [...pinot/core/realtime/stream/StreamDataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vU3RyZWFtRGF0YVByb3ZpZGVyLmphdmE=) | `0% <0%> (-87.5%)` | `0% <0%> (ø)` | | | ... and [277 more](https://codecov.io/gh/apache/incubator-pinot/pull/4680/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=footer). Last update [8249b6b...10278aa](https://codecov.io/gh/apache/incubator-pinot/pull/4680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
