Copilot commented on code in PR #16329:
URL: https://github.com/apache/pinot/pull/16329#discussion_r2198947104
##########
pom.xml:
##########
@@ -2323,6 +2323,13 @@
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
<pluginId>grpc-java</pluginId>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}</pluginArtifact>
+ <!-- For macOS users: If you encounter gRPC Java plugin issues
during build,
+ install protobuf and gRPC Java plugin globally, then uncomment
the line below:
+ brew install protobuf
+ brew install protoc-gen-grpc-java
Review Comment:
There is an extra space between `install` and `protoc-gen-grpc-java`; reduce
to a single space.
```suggestion
brew install protoc-gen-grpc-java
```
##########
README.md:
##########
@@ -141,6 +141,32 @@ For faster builds it is recommended to use `./mvnw verify
-Ppinot-fastdev`, whic
More detailed instructions can be found at [Quick
Demo](https://docs.pinot.apache.org/basics/getting-started/quick-start) section
in the documentation.
+### macOS Build Requirements
+
+If you're building Pinot on macOS and encounter issues with the gRPC Java
plugin during the build process, you may need to configure the protobuf Maven
plugin to use a specific executable path. This is a known issue on macOS ARM
(Apple Silicon) systems.
+
+To resolve this, you can install the protobuf compiler and gRPC Java plugin
globally:
+
+```bash
+# Install protobuf compiler
+brew install protobuf
+brew install protoc-gen-grpc-java
Review Comment:
There is an extra space between `install` and `protoc-gen-grpc-java`; please
remove the extra space.
```suggestion
brew install protoc-gen-grpc-java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
