Jackie-Jiang commented on code in PR #16339:
URL: https://github.com/apache/pinot/pull/16339#discussion_r2208932403
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java:
##########
@@ -268,4 +306,96 @@ int emitMetric(int numMsgsConsumed, double rateLimit,
Instant now) {
return ratioPercentage;
}
}
+
+ interface MetricEmitter {
Review Comment:
Understood. What I meant is that we don't really need this abstraction. For
the async emitter, this method is not really emitting metric. We can keep the
implementations without implementing this common interface. The 2
implementations actually have different use patterns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
