praveenc7 commented on code in PR #16018:
URL: https://github.com/apache/pinot/pull/16018#discussion_r2209156109
##########
pinot-core/src/test/java/org/apache/pinot/core/accounting/WorkloadBudgetManagerTest.java:
##########
@@ -115,4 +115,31 @@ void testConcurrentTryChargeSingleWorkload() throws
InterruptedException {
assertEquals(initialMemBudget - totalMemCharged,
remaining._memoryRemaining,
"Memory budget mismatch after concurrent updates");
}
+
+ @Test
+ void testCanAdmitQuery() {
Review Comment:
For the WorkloadBudget admission logic, I’ve tested all possible scenarios
to ensure queries are either admitted or rejected correctly. Additional test
cases for WorkloadBudgetManager were also contributed by @vvivekiyer in his
earlier PR.
We further validated this on a production host by deploying a binary and
confirmed the behavior aligns with expectations.
This implementation uses most of the scheduling logic handled by other
schedulers in this class. Further we plan to include it in our comprehensive
end-to-end validation as part of the QRI testing plan.
Since the scheduler usage is gated by a config flag, it will remain disabled
until validation is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
