Jackie-Jiang commented on code in PR #16357:
URL: https://github.com/apache/pinot/pull/16357#discussion_r2211379121
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -372,7 +372,10 @@ private <E> void processResults(long requestId, int
numServers, BiConsumer<E, Qu
// subsequent query failures
if
(getOrCreateDispatchClient(resp.getServerInstance()).getChannel().getState(false)
Review Comment:
(nit) Cache `resp.getServerInstance()` in a local variable
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -115,7 +115,10 @@ protected BrokerResponseNative processBrokerRequest(long
requestId, BrokerReques
_brokerMetrics.addMeteredTableValue(rawTableName, meter, 1);
}
if (asyncQueryResponse.getFailedServer() != null) {
Review Comment:
(nit) Cache `asyncQueryResponse.getFailedServer()` in a local variable
##########
pinot-common/src/main/java/org/apache/pinot/common/failuredetector/FailureDetector.java:
##########
@@ -69,12 +70,28 @@ public interface FailureDetector {
/**
* Marks a server as healthy.
*/
- void markServerHealthy(String instanceId);
+ @Deprecated
+ default void markServerHealthy(String instanceId) {
+ markServerHealthy(instanceId, null);
+ };
+
+ /**
+ * Marks a server as healthy.
+ */
+ void markServerHealthy(String instanceId, @Nullable String hostName);
Review Comment:
You should also annotate the implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
