somandal commented on code in PR #16341:
URL: https://github.com/apache/pinot/pull/16341#discussion_r2211487297
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -387,6 +391,24 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
tierToInstancePartitionsMap, targetAssignment, preChecksResult,
summaryResult);
}
+ if (downtime &&
!StringUtils.isEmpty(tableConfig.getValidationConfig().getPeerSegmentDownloadScheme()))
{
Review Comment:
But in `TableConfigUtils` they have a function `isValidPeerDownloadScheme`
which validates that the only values it can have are "https" or "http", same
with documentation:
https://docs.pinot.apache.org/operators/operating-pinot/decoupling-controller-from-the-data-path#table-config
I can change it, but I kept it this way expecting that the validations won't
allow other values. I could be wrong though.
@noob-se7en @Jackie-Jiang do you know if we need to also check for empty ""
as a valid peer download scheme in the code for things like backward
compatibility or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
