Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP
BY with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332778952
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/SimpleIndexedTable.java
##########
@@ -116,11 +158,20 @@ public int size() {
@Override
public Iterator<Record> iterator() {
- return _records.iterator();
+ return _iterator;
+ }
+
+ @Override
+ public void finish(boolean sort) {
+ sortAndResize(_maxCapacity);
Review comment:
Add a TODO here for resize without sort
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
